Issue 21291: subprocess Popen objects are not thread safe w.r.t. wait() and returncode being set

Executing the supplied test code you either get:

sys.version = 3.4.0+ (3.4:635817da596d, Apr 17 2014, 14:30:34) 
[GCC 4.6.3]
--------
Results with <class 'subprocess.Popen'>:
  r0    = None, expected None 
  r1    = None, expected None 
  ri0   = None, expected None 
  ri1   = -9, expected -9 
  ri2   = -9, expected -9 
  r2    = 0, expected -9 *** MISMATCH ***
  r3    = 0, expected -9 *** MISMATCH ***

or

Results with <class 'subprocess.Popen'>:
  r0    = None, expected None 
  r1    = None, expected None 
  ri0   = None, expected None 
  ri1   = -9, expected -9 
  ri2   = -9, expected -9 
  r2    = 0, expected -9 *** MISMATCH ***
  r3    = 0, expected -9 *** MISMATCH ***

At first glance it appears that the .returncode attribute is not safely set after the wait call... This test code is using the Popen object from multiple threads at once.

Attaching a proposed fix for this issue.  It should make the wait() and poll() methods thread safe.  I need to turn the reproducer code into an actual test case and add more test cases for coverage of all code paths being touched.

I haven't examined the windows side of this code for the issue, it may also be useful there.

New changeset 5d745d97b7da by Gregory P. Smith in branch '3.4':
subprocess's Popen.wait() is now thread safe so that multiple threads
http://hg.python.org/cpython/rev/5d745d97b7da

New changeset df45d0336dad by Gregory P. Smith in branch 'default':
subprocess's Popen.wait() is now thread safe so that multiple threads
http://hg.python.org/cpython/rev/df45d0336dad

This fix is also present in subprocess32 3.2.6 on PyPI for use on Python 2.

resolution: fixed
stage: commit review