Issue 21783: smtpd.py does not allow multiple helo/ehlo commands

Sending HELO or EHLO more then once causes smtpd.SMTPChannel to respond with b'503 Duplicate HELO/EHLO\r\n' (see Lib/test/test_smtpd.py:124 for an example).

My interpretation of RFC 821, section 4.1.1.5 is that multiple HELO commands are fine outside a mail transaction and a second HELO is eauivalent to a RSET during a mail transaction (undoing any changes made by previous greetings).

I would propose to reject greetings during mail transactiond (thats what RSET is for) and else accept them. The question is how we should handle backwards compatibility here.

I am willing to work on this right after #21725.

Here is the patch how it should look like at some point. Question being: How should we handle backwards-compatibility?

I don't have much interest in working on this for smtpd.py any more.  We have an asyncio-based version that's much better, albeit Python 3 only.

https://github.com/aio-libs/aiosmtpd

This same issue is open over there; if you're still interested in this, maybe take a look at contributing a fix for aiosmtpd.

https://github.com/aio-libs/aiosmtpd/issues/78

Thanks for pointing me at this, Berry! I added a PR for aiosmtpd at https://github.com/aio-libs/aiosmtpd/pull/106

*Barry :P

This is now fixed in aiosmtpd HEAD (what will be 1.1)

I'm going to close this issue here even though smtpd.py isn't fixed since it's unlikely that anybody wants to keep working on smtpd.py.  Feel free to reopen it if you do.

stage: resolved