Issue4962
Created on 2009-01-16 10:28 by yuhl, last changed 2022-04-11 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue4962-py27.diff | orsenthil, 2009-03-30 21:35 | |||
| issue4962-py3k.diff | orsenthil, 2009-03-30 21:35 | |||
| Messages (6) | |||
|---|---|---|---|
| msg79946 - (view) | Author: Cédric BRINER (yuhl) | Date: 2009-01-16 10:28 | |
Hi, I'd like to add the ability to parse nfs url (rfc2224). Which look like: nfs://server/my/path To do this, we only need to add 'nfs' in uses_netloc to make it work cEd |
|||
| msg79950 - (view) | Author: Senthil Kumaran (orsenthil) * | Date: 2009-01-16 10:43 | |
> I'd like to add the ability to parse nfs url (rfc2224). Which look like:
> nfs://server/my/path
>
> To do this, we only need to add 'nfs' in uses_netloc to make it work
Do you encounter any errors or weird behaviors while using nfs url?
The RFC2224 for NFS just says it is for local and network files and
in turn uses specification in RFC 1738 "Uniform Resource Locators".
So, I don't think any problem or breakage should occur with NFS
('nfs', '', '//server//a/b/c/d/e/f', '', '', '')
If you have done the research already, can you please explain what
difference will adding 'nfs' to uses_netloc do in urlparse.py.
|
|||
| msg80150 - (view) | Author: Cédric BRINER (yuhl) | Date: 2009-01-19 09:50 | |
> Do you encounter any errors or weird behaviors while using nfs url?
Do you mean: Do I have problem using the python module in conjunction of
urlparse ?
No, because, I'm not yet using it. But I would like to do it. And I find
it strange that it can not find the host by itself.
>('nfs', '', '//server//a/b/c/d/e/f', '', '', '')
>If you have done the research already, can you please explain what
>difference will adding 'nfs' to uses_netloc do in urlparse.py.
As much as I've looked at the code, the uses_netloc provide an easy way
to tell urlparse.py if such scheme as nfs is composed
by a net location (host[:port]). Which is the case. Modifying
uses_netloc by addind 'nfs' into it will transform the following:
nfsurl : 'nfs://server//a/b/c/d/e/f'
in urlparse from:
('nfs', '', '//server//a/b/c/d/e/f', '', '', '')
to
('nfs', 'server', '//a/b/c/d/e/f', '', '', '')
|
|||
| msg84656 - (view) | Author: Senthil Kumaran (orsenthil) * | Date: 2009-03-30 21:34 | |
Patch to fix this. Looked into the RFCs and I do not find a reason why
the nfs://server/path/to/file.txt should not be parsed as:
>>> urlparse.urlsplit('nfs://server/path/to/file.txt')
SplitResult(scheme='nfs', netloc='server', path='/path/to/file.txt',
query='', fragment='')
Patch and Tests added.
|
|||
| msg84658 - (view) | Author: Jeremy Hylton (jhylton) | Date: 2009-03-30 21:40 | |
looks good to me |
|||
| msg84671 - (view) | Author: Senthil Kumaran (orsenthil) * | Date: 2009-03-30 22:02 | |
fixed. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:56:44 | admin | set | github: 49212 |
| 2009-03-30 22:51:37 | orsenthil | set | status: open -> closed |
| 2009-03-30 22:02:06 | orsenthil | set | assignee: orsenthil resolution: fixed messages: + msg84671 |
| 2009-03-30 21:40:09 | jhylton | set | nosy:
+ jhylton messages: + msg84658 |
| 2009-03-30 21:35:21 | orsenthil | set | files: + issue4962-py3k.diff |
| 2009-03-30 21:35:08 | orsenthil | set | files:
+ issue4962-py27.diff keywords: + patch |
| 2009-03-30 21:34:51 | orsenthil | set | messages: + msg84656 |
| 2009-02-13 01:46:31 | ajaksu2 | set | nosy: + jjlee |
| 2009-01-19 09:50:08 | yuhl | set | messages: + msg80150 |
| 2009-01-16 10:43:07 | orsenthil | set | nosy:
+ orsenthil messages: + msg79950 |
| 2009-01-16 10:28:24 | yuhl | create | |