Issue 5627: PyDict_SetItemString() fails when the second argument is null

PyDict_SetItemString() fails when the second argument (key) is null
pointer. It occurs because PyString_FromString(key) call doesn't check
for null pointer and if we're in a disabled assert environment the
assert() is not caught and strlen() fails.

I don't know what is the best fix but we have two possibilities:

(i) check the second argument in PyDict_SetItemString() before calling
PyString_FromString() and returns null if that argument is null;
(ii) replace the assert() in PyString_FromString() to 'if (str == NULL)
return NULL;'.

This bug was reported as a PostgreSQL bug at [1].

[1] http://archives.postgresql.org/pgsql-hackers/2009-03/msg01344.php

It seems PyDict_DelItemString() and PyDict_SetItem() suffer from the
same disease. :( Both use assert() to detect a null pointer but fail to
prevent it. As I stated in the previous comment, maybe the right fix is
to replace assert() with the 'if (foo == NULL) return whatever'.

I am not sure why you consider this a bug. You should certainly not pass
NULL pointers around where the docs do not explicitly allow this.

I know that it is a good programming practice checking null pointers but
sometimes programmers are lazy. ;)  I still think that high level
functions should check for null pointers.

Raymond, do you have an opinion about this?

I recommend rejecting this one.  The assert is sufficient for
third-party modules to run their tests and detect bad calls.  The code
path is too critical to add another check.

Closing.

messages: + msg85145

nosy: + loewis
messages: + msg85134

assignee: rhettinger -> loewis

messages: + msg85114
nosy: + rhettinger

nosy: + georg.brandl
messages: + msg84978

resolution: wont fix