Message324641
| Author |
zach.ware |
| Recipients |
Jim.Jewett, amaury.forgeotdarc, dino.viehland, giampaolo.rodola, gregory.p.smith, midnightdf, pitrou, r.david.murray, vstinner, zach.ware |
| Date |
2018-09-05.14:53:03 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1536159183.8.0.56676864532.issue8110@psf.upfronthosting.co.za> |
| In-reply-to |
|
| Content |
The real question isn't "are we on Windows?" but rather "should we use msvcrt/_winapi or _posixsubprocess/select?", which is what my PR is designed to better fit. I could see how we wouldn't want to backport that patch to maintenance branches, though; it's a significant rearrangement. If we do want to backport *a* fix, I agree that simply adding `or os.name == 'nt'` should be sufficiently low-impact. |
|