Message339787
| Author | vstinner |
|---|---|
| Recipients | asvetlov, cheryl.sabella, giampaolo.rodola, jaraco, josiah.carlson, loewis, neologix, pablogsal, pitrou, vstinner |
| Date | 2019-04-09.17:19:36 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1554830376.63.0.916382987176.issue35934@roundup.psfhosted.org> |
| In-reply-to |
| Content | |
|---|---|
> Those are old failures (+/- 17 hours ago). I committed: > https://github.com/python/cpython/pull/12735 Oh, you wrote "BPO-" rather than "bpo-" and so your commit wasn't mentioned here: commit 8702b67dad62a9084f6c1823dce10653743667c8 Author: Giampaolo Rodola <g.rodola@gmail.com> Date: Tue Apr 9 04:42:06 2019 +0200 BPO-17561: set create_server backlog default to None (GH-12735) It turns out doing socket.listen(0) does not equal to "choose a reasonable default". It actually means "set backlog to 0". As such set backlog=None as the default for socket.create_server. Fixes the following BB failures: https://github.com/python/cpython/pull/11784#issuecomment-481036369 Ref. BPO-1756, GH-11784. > ...which fixed them. Oh, great! Thanks for the fix. Sorry, I was 10 days late to handle emails from the buildbot-status mailing list. I only reported failures, I didn't check if it has been fixed in the meanwhile. I close again the issue. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2019-04-09 17:19:36 | vstinner | set | recipients: + vstinner, loewis, jaraco, pitrou, giampaolo.rodola, josiah.carlson, asvetlov, neologix, cheryl.sabella, pablogsal |
| 2019-04-09 17:19:36 | vstinner | set | messageid: <1554830376.63.0.916382987176.issue35934@roundup.psfhosted.org> |
| 2019-04-09 17:19:36 | vstinner | link | issue35934 messages |
| 2019-04-09 17:19:36 | vstinner | create | |