Message61765
| Author | donmez |
|---|---|
| Recipients | alexandre.vassalotti, christian.heimes, donmez, gregory.p.smith, gvanrossum, loewis, nnorwitz |
| Date | 2008-01-28.03:02:22 |
| SpamBayes Score | 0.0024604835 |
| Marked as misclassified | No |
| Message-id | <1201489343.89.0.700346713424.issue1621@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
Neal, I'll try to answer your questions one by one, first with _csv.c compiler issues : Modules/_csv.c:969: warning: assuming signed overflow does not occur when simplifying conditional to constant There is a check inside loop like this: if (c == '\0') break; Instead of this if we do the check in the for : + for (i = 0; i < strlen(field) ; i++) { and remove the if check compiler no longer issues a warning also csv test passes with this. Attached patch implements this optimization. Guido, you don't have to shout, you know noone pays me per python bugreport I create :) |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2008-01-28 03:02:24 | donmez | set | spambayes_score: 0.00246048 -> 0.0024604835 recipients: + donmez, gvanrossum, loewis, nnorwitz, gregory.p.smith, christian.heimes, alexandre.vassalotti |
| 2008-01-28 03:02:23 | donmez | set | spambayes_score: 0.00246048 -> 0.00246048 messageid: <1201489343.89.0.700346713424.issue1621@psf.upfronthosting.co.za> |
| 2008-01-28 03:02:23 | donmez | link | issue1621 messages |
| 2008-01-28 03:02:22 | donmez | create | |