[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

srinivasreddy commented Oct 26, 2018

Copy link
Contributor Author

Should supersede #4641.

@Mariatta Please review the News blurb.

Copy link

Mariatta was mentioned, but she's out of open source for the rest of September 2018, and parts of October 2018 . Be aware she might not get to this until November 2018.
(I'm a bot)

Copy link
Contributor

akuchling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refactoring looks like a pleasant clean-up for the code. I don't think it needs any additions to the test suite, so I don't think any further work is needed.

Copy link
Contributor

On looking like the conflict, it looks like someone has already applied basically the same changes from PR-4641. So I'll just close this PR.

akuchling closed this Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants