[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

vxgmichel commented Oct 29, 2018 •
edited
Loading

The call to _untrack_reader is performed too soon, causing the protocol to forget about the reader before connection_lost can run and feed the EOF to the reader.

This PR currently fixes the issue by removing the _untrack_reader call and definition altogether.

https://bugs.python.org/issue35065

Remove StreamReaderProtocol._untrack_reader
214adcf 
The call to `_untrack_reader` is performed too soon, causing the protocol
to forget about the reader before `connection_lost` can run and feed the
EOF to the reader. See bpo-35065.
Add the Misc/NEWS entry for bpo-35065
5e74a88
Copy link
Contributor

asvetlov commented Nov 8, 2018

Thank you for the fix, it looks correct.
Initially _on_reader_gc() callback had more complex logic, it was not safe to call it with closed transport.
The current code processes the case correctly, removing _untrack_reader is safe.

asvetlov merged commit fd512d7 into python:master Nov 8, 2018
Copy link

bedevere-bot commented Nov 8, 2018

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

vxgmichel deleted the bpo-35065 branch November 8, 2018 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

asvetlov asvetlov approved these changes

1st1 Awaiting requested review from 1st1

gpshead Awaiting requested review from gpshead

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants