[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented Nov 7, 2018 •
edited by bedevere-bot
Loading

The constructor of subprocess.CalledProcessError in the check_output function had an extra None in it.
(cherry picked from commit b939250)

Co-authored-by: Pablo Galindo Pablogsal@gmail.com

https://bugs.python.org/issue34011

Fix the construction of subprocess.CalledProcessError in test_venv (p…
da59fad 
…ythonGH-10400)

The constructor of subprocess.CalledProcessError in the check_output function had an extra None in it.
(cherry picked from commit b939250)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
bedevere-bot mentioned this pull request Nov 7, 2018
Merged
bedevere-bot added skip news tests Tests in the Lib/test dir awaiting review labels Nov 7, 2018
pablogsal changed the title [3.7] Fix the construction of subprocess.CalledProcessError in test_venv (GH-10400) [3.7] bpo-34011: Fix the construction of subprocess.CalledProcessError in test_venv (GH-10400) Nov 7, 2018
Copy link
Contributor Author

miss-islington commented Nov 7, 2018

@pablogsal: Status check is done, and it's a success ✅ .

miss-islington merged commit b097f9f into python:3.7 Nov 7, 2018
miss-islington deleted the backport-b939250-3.7 branch November 7, 2018 22:39
Copy link
Contributor Author

miss-islington commented Nov 7, 2018

@pablogsal: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants