[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

vstinner commented Dec 12, 2018 •
edited by bedevere-bot
Loading

Python 2.4 dropped MacOS 9 support. The macpath module was deprecated
in Python 3.7. This change removes it.

https://bugs.python.org/issue35471

bpo-35471: Remove the macpath module
cf5fce8 
Python 2.4 dropped MacOS 9 support. The macpath module was deprecated
in Python 3.7. This change removes it.
vstinner requested a review from a team as a code owner December 12, 2018 15:26
serhiy-storchaka reviewed Dec 12, 2018
View reviewed changes
PCbuild/lib.pyproj
</ItemGroup>
<Import Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\Python Tools\Microsoft.PythonTools.targets" />
</Project> No newline at end of file
</Project>
Copy link
Member

serhiy-storchaka Dec 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change.

Copy link
Member Author

vstinner Dec 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like my text editor (vim) likes to add newline. Well, this change shouldn't hurt :-)

Tools/freeze/freeze.py

# default the exclude list for each platform
if win: exclude = exclude + [
'dos', 'dospath', 'mac', 'macpath', 'macfs', 'MACFS', 'posix', ]
Copy link
Member

serhiy-storchaka Dec 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'dospath'? Seriously? 😉

Copy link
Member Author

vstinner Dec 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know any of these modules (except of "posix"), so I chose to not touch this old code...

serhiy-storchaka requested a review from a team December 12, 2018 16:08
Copy link
Member Author

vstinner commented Dec 12, 2018

@serhiy-storchaka: I made two changes, see my second commit.

ned-deily approved these changes Dec 13, 2018
View reviewed changes
Copy link
Member

ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Member Author

vstinner commented Dec 14, 2018

@ronaldoussoren wrote "I'm in favour of removing macpath.":
https://bugs.python.org/issue35471#msg331702

vstinner merged commit d7538dd into python:master Dec 14, 2018
vstinner deleted the remove_macpath branch December 14, 2018 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka left review comments

ned-deily ned-deily approved these changes

ronaldoussoren Awaiting requested review from ronaldoussoren

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants