[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

taleinat commented Jan 17, 2019 •
edited by bedevere-bot
Loading

This is an alternative solution to PR #11552.

Here, instead of checking that zero_char_width changes, the test just checks that .load_font() is called.

https://bugs.python.org/issue35730

taleinat requested a review from terryjreedy January 17, 2019 07:46
bedevere-bot added tests Tests in the Lib/test dir awaiting merge labels Jan 17, 2019
taleinat mentioned this pull request Jan 17, 2019
Closed
taleinat added skip news type-bug An unexpected behavior, bug, or error labels Jan 17, 2019
terryjreedy changed the title bpo-35730: fix test_reload() by avoiding checking the actual zero_char_width bpo-35730: IDLE - test squeezer reload() by checking load_font called Jan 18, 2019
terryjreedy changed the title bpo-35730: IDLE - test squeezer reload() by checking load_font called bpo-35730: IDLE - test squeezer reload() by checking load_font() Jan 18, 2019
Copy link
Member

terryjreedy commented Jan 18, 2019 •
edited
Loading

Thanks. This should be as dependable as any other 'function called' test. Thanks.

terryjreedy merged commit e55cf02 into python:master Jan 18, 2019
Copy link
Contributor

miss-islington commented Jan 18, 2019

Thanks @taleinat for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

Copy link

bedevere-bot commented Jan 18, 2019

GH-11601 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 18, 2019
bpo-35730: IDLE - test squeezer reload() by checking load_font() (pyt…
159d575 
…honGH-11585)

(cherry picked from commit e55cf02)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
miss-islington added a commit that referenced this pull request Jan 18, 2019
bpo-35730: IDLE - test squeezer reload() by checking load_font() (GH-…
237f864 
…11585)

(cherry picked from commit e55cf02)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

terryjreedy Awaiting requested review from terryjreedy

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants