[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

rhettinger commented Feb 1, 2019 •
edited by bedevere-bot
Loading

rhettinger added the performance Performance or resource usage label Feb 1, 2019
eamanu approved these changes Feb 2, 2019
View reviewed changes
Copy link
Contributor

eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rhettinger merged commit f75d59e into python:master Feb 3, 2019
rhettinger deleted the var_benchmark branch February 3, 2019 06:55
scoder reviewed Feb 16, 2019
View reviewed changes
Tools/scripts/var_access_benchmark.py
a[0]=1; a[0]=1; a[0]=1; a[0]=1; a[0]=1
a[0]=1; a[0]=1; a[0]=1; a[0]=1; a[0]=1

def write_dict(trials=trials, a={0: 1}):
Copy link
Contributor

scoder Feb 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a dict read/write benchmark with short str keys would probably also be interesting in comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

scoder scoder left review comments

+1 more reviewer

eamanu eamanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

performance Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants