[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented Feb 15, 2019

Previously, debug print( would cause the interpreter to exit on a SyntaxError whereas print( would properly display the error and return to the pdb prompt.

This patch fixes this by pre-compiling the code before passing it to Pdb.run.

https://bugs.python.org/issue35931
(cherry picked from commit 4327705)

Co-authored-by: Daniel Hahler github@thequod.de

https://bugs.python.org/issue35931

…GH-11782)

Previously, `debug print(` would cause the interpreter to exit on a SyntaxError whereas `print(` would properly display the error and return to the pdb prompt.

This patch fixes this by pre-compiling the code before passing it to `Pdb.run`.

https://bugs.python.org/issue35931
(cherry picked from commit 4327705)

Co-authored-by: Daniel Hahler <github@thequod.de>
Copy link
Contributor Author

@blueyed: Status check is done, and it's a success ✅ .

1 similar comment
Copy link
Contributor Author

@blueyed: Status check is done, and it's a success ✅ .

miss-islington merged commit 6f35219 into python:3.7 Feb 15, 2019
miss-islington deleted the backport-4327705-3.7 branch February 15, 2019 21:19
Copy link
Contributor

blueyed commented Mar 9, 2019

This breaks the API (you cannot pass in a compile() object anymore), and there is a better patch waiting, which then also should get backported, or this one being reverted.
See https://bugs.python.org/issue35931#msg337575.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants