Several loops use int variables instead of Py_ssize_t. The one in array.remove() definitely can lead to a crash, for the others I haven't verified if it actually crashes. But using Py_ssize_t instead of int is more correct in any case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several loops use
intvariables instead ofPy_ssize_t. The one inarray.remove()definitely can lead to a crash, for the others I haven't verified if it actually crashes. But usingPy_ssize_tinstead ofintis more correct in any case.I also added a bunch of tests for arrays >=2G.
https://bugs.python.org/issue36285