[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

skrungly commented Apr 12, 2019

this PR slightly tweaks the behaviour of str.capitalize so that it puts the first character into titlecase rather than uppercase. this only really changes the result for strings starting with digraphs or ligatures.

this my first contribution here so i hope everything is correct! :) i wasn't too sure exactly which part of the documentation needed to be changed so i just put what i assumed was right.

https://bugs.python.org/issue36549

https://bugs.python.org/issue36549

Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Copy link
Member

zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, just need the CLA to come through

Copy link
Contributor

I think this may have been merged too soon. Serhiy had made a list on the bug tracker (https://bugs.python.org/issue36549#msg339878), and I think that this PR was missing some necessary changes.

Copy link
Contributor Author

I think that this PR was missing some necessary changes.

if you don't mind me asking, what did i miss? i thought i had tackled all of the points made on the bug tracker :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants