[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented May 14, 2019 •
edited by bedevere-bot
Loading

MultiprocessThread.kill() now closes stdout and stderr to prevent
popen.communicate() to hang.
(cherry picked from commit c923c34)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue36719

bpo-36719: Fix regrtest MultiprocessThread (pythonGH-13301)
3b13b08 
MultiprocessThread.kill() now closes stdout and stderr to prevent
popen.communicate() to hang.
(cherry picked from commit c923c34)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
bedevere-bot mentioned this pull request May 14, 2019
Merged
vstinner approved these changes May 14, 2019
View reviewed changes
Copy link
Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Copy link
Contributor Author

miss-islington commented May 14, 2019

@vstinner: Status check is done, and it's a failure ❌ .

2 similar comments
Copy link
Contributor Author

miss-islington commented May 14, 2019

@vstinner: Status check is done, and it's a failure ❌ .

Copy link
Contributor Author

miss-islington commented May 14, 2019

@vstinner: Status check is done, and it's a failure ❌ .

vstinner merged commit d8e123a into python:3.7 May 14, 2019
miss-islington deleted the backport-c923c34-3.7 branch May 14, 2019 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants