[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

jdemeyer commented May 21, 2019 •
edited
Loading

After implementing PEP 590 (#13185)

https://bugs.python.org/issue36974

jdemeyer force-pushed the pep590_remove_hasfastcall branch from 5b4542e to 8e75c00 Compare May 22, 2019 15:05
jdemeyer marked this pull request as ready for review May 22, 2019 18:51
jdemeyer force-pushed the pep590_remove_hasfastcall branch from 8e75c00 to b4b9775 Compare May 29, 2019 11:58
jdemeyer force-pushed the pep590_remove_hasfastcall branch from b4b9775 to 8104ac3 Compare May 29, 2019 18:37
encukou approved these changes May 29, 2019
View reviewed changes
Copy link
Member

encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
(Not merging now as I won't be able to watch buildbots)

jdemeyer mentioned this pull request May 30, 2019
Merged
encukou merged commit c145f3b into python:master May 30, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
bpo-36974: remove _PyObject_HasFastCall (pythonGH-13460)
294faef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou encukou approved these changes

1st1 Awaiting requested review from 1st1

asvetlov Awaiting requested review from asvetlov

rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants