[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented Jun 1, 2019

Fixed QueueListener in order to avoid random deadlocks.
Unable to add regression tests atm due to time constraints, will add it in a bit.
Regarding implementation, although it's nested, it does not cause performance issues whatsoever, and does not call task_done() in case of an exception (which is the right thing to do IMHO).

https://bugs.python.org/issue36813
(cherry picked from commit 6b282e1)

Co-authored-by: Bar Harel bzvi7919@gmail.com

https://bugs.python.org/issue36813

…ythonGH-13113)

Fixed QueueListener in order to avoid random deadlocks.
Unable to add regression tests atm due to time constraints, will add it in a bit.
Regarding implementation, although it's nested, it does not cause performance issues whatsoever, and does not call task_done() in case of an exception (which is the right thing to do IMHO).

https://bugs.python.org/issue36813
(cherry picked from commit 6b282e1)

Co-authored-by: Bar Harel <bzvi7919@gmail.com>
Copy link
Contributor Author

@bharel: Status check is done, and it's a success ✅ .

miss-islington merged commit f286e03 into python:3.7 Jun 1, 2019
miss-islington deleted the backport-6b282e1-3.7 branch June 1, 2019 09:36
Copy link
Contributor Author

@bharel: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants