[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

rhettinger commented Jun 5, 2019 •
edited by bedevere-bot
Loading

rhettinger added the performance Performance or resource usage label Jun 5, 2019
pablogsal reviewed Jun 5, 2019
View reviewed changes
Copy link
Member

pablogsal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this :)

I left some comments regarding a couple of missing things.

pablogsal approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rhettinger merged commit e985804 into python:master Jun 5, 2019
Copy link
Contributor

miss-islington commented Jun 5, 2019

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

Copy link

bedevere-bot commented Jun 5, 2019

GH-13853 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jun 5, 2019
bpo-37165: Convert _count_elements to the argument clinic (GH-13848)
21ce245 
(cherry picked from commit e985804)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
Copy link
Member

serhiy-storchaka commented Jun 7, 2019

Usually we do not add a NEWS entry when convert a module or separate functions to Argument Clinic, as such conversion does not change the behavior. In this particular case the converted function is private, so there is even less reasons to add a NEWS entry.

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
bpo-37165: Convert _count_elements to the argument clinic (pythonGH-1…
4e5ad6c 
…3848)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal pablogsal approved these changes

serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

performance Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants