[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

vstinner commented Jun 10, 2019 •
edited
Loading

Fix test_threading.test_threads_join_2(): run the test into a
subprocess, rather than in a subinterpreter, to avoid a race
condition.

https://bugs.python.org/issue36402

vstinner requested a review from pablogsal June 10, 2019 20:42
bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Jun 10, 2019
bpo-36402: Fix test_threading.test_threads_join_2()
43dce09 
Fix test_threading.test_threads_join_2(): run the test into a
subprocess, rather than in a subinterpreter, to avoid a race
condition.
vstinner changed the title bpo-13889: Fix test_threading.test_threads_join_2() bpo-36402: Fix test_threading.test_threads_join_2() Jun 10, 2019
vstinner changed the title bpo-36402: Fix test_threading.test_threads_join_2() [WIP] bpo-36402: Fix test_threading.test_threads_join_2() Jun 10, 2019
Copy link
Member Author

vstinner commented Jun 10, 2019

I'm not sure that this fix is correct. The purpose of the test is to ensure that Py_EndInterpreter() joins properly threads: commit 7b47699.

Copy link
Member Author

vstinner commented Jun 10, 2019

Nah, this change is plain wrong. https://bugs.python.org/issue36402 is a real bug, this change only hides it. PR #13948 is the good fix.

vstinner closed this Jun 10, 2019
vstinner deleted the fix_threads_join_2 branch June 10, 2019 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal Awaiting requested review from pablogsal

Assignees

No one assigned

Labels

awaiting core review DO-NOT-MERGE tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants