[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

pablogsal commented Jun 24, 2019 •
edited by bedevere-bot
Loading

pablogsal requested a review from rhettinger as a code owner June 24, 2019 23:01
pablogsal self-assigned this Jun 24, 2019
Copy link
Member

vstinner commented Jun 24, 2019

test_queue didn't catch this issue, so test_queue should be fixed somehow.

IMHO test_queue should be rewritten using something like that:

py_functools = support.import_fresh_module('functools', blocked=['_functools'])
c_functools = support.import_fresh_module('functools', fresh=['_functools'])

pablogsal force-pushed the fix_import branch 2 times, most recently from 06595d2 to 3713388 Compare June 24, 2019 23:37
vstinner reviewed Jun 25, 2019
View reviewed changes
vstinner approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suggest to rephrase the commit title, mayby: "Fix pure Python implementation of queue".

I may be interesting to add NEWS entry, and maybe backport this change to 3.7 and 3.8. You have to open a bpo issue in this case (to get a bpo number).

pablogsal changed the title Fix import exception for queue.py when accelerator is not pressent bpo-37394: Fix pure Python implementation of queue Jun 25, 2019
pablogsal merged commit 3f5b908 into python:master Jun 25, 2019
Copy link
Contributor

miss-islington commented Jun 25, 2019

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

pablogsal deleted the fix_import branch June 25, 2019 01:53
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 25, 2019
bpo-37394: Fix pure Python implementation of the queue module (python…
aecfff3 
…GH-14351)

(cherry picked from commit 3f5b908)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Copy link

bedevere-bot commented Jun 25, 2019

GH-14362 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jun 25, 2019
bpo-37394: Fix pure Python implementation of the queue module (GH-14351)
5bf3b89 
(cherry picked from commit 3f5b908)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
bpo-37394: Fix pure Python implementation of the queue module (python…
3ed8388 
…GH-14351)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
bpo-37394: Fix pure Python implementation of the queue module (python…
70346cf 
…GH-14351)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

rhettinger Awaiting requested review from rhettinger

Assignees

pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants