[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light

bpo-37428: Don't set PHA verify flag on client side by tiran · Pull Request #14421 · python/cpython

tiran

tiran mentioned this pull request

Jun 27, 2019

Closed

alex approved these changes Jun 29, 2019

SSLContext.post_handshake_auth = True no longer sets
SSL_VERIFY_POST_HANDSHAKE verify flag for client connections. Although the
option is documented as ignored for clients, OpenSSL implicitly enables cert
chain validation when the flag is set.

Signed-off-by: Christian Heimes <christian@python.org>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 1, 2019

SSLContext.post_handshake_auth = True no longer sets
SSL_VERIFY_POST_HANDSHAKE verify flag for client connections. Although the
option is documented as ignored for clients, OpenSSL implicitly enables cert
chain validation when the flag is set.

Signed-off-by: Christian Heimes <christian@python.org>

https://bugs.python.org/issue37428
(cherry picked from commit f0f5930)

Co-authored-by: Christian Heimes <christian@python.org>

tiran added a commit to tiran/cpython that referenced this pull request

Jul 1, 2019

…4421)

SSLContext.post_handshake_auth = True no longer sets
SSL_VERIFY_POST_HANDSHAKE verify flag for client connections. Although the
option is documented as ignored for clients, OpenSSL implicitly enables cert
chain validation when the flag is set.

Signed-off-by: Christian Heimes <christian@python.org>

https://bugs.python.org/issue37428
(cherry picked from commit f0f5930)

Co-authored-by: Christian Heimes <christian@python.org>

miss-islington added a commit that referenced this pull request

Jul 1, 2019
…H-14493)

SSLContext.post_handshake_auth = True no longer sets
SSL_VERIFY_POST_HANDSHAKE verify flag for client connections. Although the
option is documented as ignored for clients, OpenSSL implicitly enables cert
chain validation when the flag is set.

Signed-off-by: Christian Heimes <christian@python.org>



https://bugs.python.org/issue37428
(cherry picked from commit f0f5930)


Co-authored-by: Christian Heimes <christian@python.org>


https://bugs.python.org/issue37428

tiran deleted the bpo-37428-pha-server branch

July 1, 2019 07:06

ned-deily pushed a commit to ned-deily/cpython that referenced this pull request

Jul 2, 2019
…4421) (pythonGH-14493)

SSLContext.post_handshake_auth = True no longer sets
SSL_VERIFY_POST_HANDSHAKE verify flag for client connections. Although the
option is documented as ignored for clients, OpenSSL implicitly enables cert
chain validation when the flag is set.

Signed-off-by: Christian Heimes <christian@python.org>



https://bugs.python.org/issue37428
(cherry picked from commit f0f5930)


Co-authored-by: Christian Heimes <christian@python.org>


https://bugs.python.org/issue37428

lisroach pushed a commit to lisroach/cpython that referenced this pull request

Sep 10, 2019
SSLContext.post_handshake_auth = True no longer sets
SSL_VERIFY_POST_HANDSHAKE verify flag for client connections. Although the
option is documented as ignored for clients, OpenSSL implicitly enables cert
chain validation when the flag is set.

Signed-off-by: Christian Heimes <christian@python.org>



https://bugs.python.org/issue37428

DinoV pushed a commit to DinoV/cpython that referenced this pull request

Jan 14, 2020
SSLContext.post_handshake_auth = True no longer sets
SSL_VERIFY_POST_HANDSHAKE verify flag for client connections. Although the
option is documented as ignored for clients, OpenSSL implicitly enables cert
chain validation when the flag is set.

Signed-off-by: Christian Heimes <christian@python.org>



https://bugs.python.org/issue37428

rickprice added a commit to ActiveState/cpython that referenced this pull request

Jan 26, 2024
…pile

rickprice added a commit to ActiveState/cpython that referenced this pull request

Jan 26, 2024
…pile

rickprice added a commit to ActiveState/cpython that referenced this pull request

Jun 26, 2024
…pile