[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

tiran commented Jul 1, 2019 •
edited by bedevere-bot
Loading

SSLContext.post_handshake_auth = True no longer sets
SSL_VERIFY_POST_HANDSHAKE verify flag for client connections. Although the
option is documented as ignored for clients, OpenSSL implicitly enables cert
chain validation when the flag is set.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue37428
(cherry picked from commit f0f5930)

https://bugs.python.org/issue37428

[3.8] bpo-37428: Don't set PHA verify flag on client side (pythonGH-1…
196f2b5 
…4421)

SSLContext.post_handshake_auth = True no longer sets
SSL_VERIFY_POST_HANDSHAKE verify flag for client connections. Although the
option is documented as ignored for clients, OpenSSL implicitly enables cert
chain validation when the flag is set.

Signed-off-by: Christian Heimes <christian@python.org>

https://bugs.python.org/issue37428
(cherry picked from commit f0f5930)

Co-authored-by: Christian Heimes <christian@python.org>
bedevere-bot mentioned this pull request Jul 1, 2019
Merged
bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting core review labels Jul 1, 2019
tiran changed the title [3.8] bpo-37428: Don't set PHA verify flag on client side (GH-14421) [3.8] bpo-37428: Don't set PHA verify flag on client side (GH-14494) Jul 1, 2019
tiran merged commit f22c4cf into python:3.8 Jul 1, 2019
Copy link
Member Author

tiran commented Jul 1, 2019 •
edited by bedevere-bot
Loading

GH limits the title to 72 chars and didn't let me merge this PR with commit message [3.8] [bpo-37428](https://bugs.python.org/issue37428): Don't set PHA verify flag on client side (GH-14421) (GH-14493).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants