[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

methane commented Jul 5, 2019 •
edited by bedevere-bot
Loading

methane added skip news type-bug An unexpected behavior, bug, or error labels Jul 5, 2019
jdemeyer requested changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

jdemeyer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to initialize v = NULL and you need to handle the case v == NULL in onError. See #14600

methane closed this Jul 5, 2019
methane deleted the fix-refleak branch July 5, 2019 10:23
methane restored the fix-refleak branch July 5, 2019 10:24
methane reopened this Jul 5, 2019
Copy link
Member Author

methane commented Jul 5, 2019

You need to initialize v = NULL and you need to handle the case v == NULL in onError. See #14600

Why?

    v = normalizestring(encoding);
    if (v == NULL)
        goto onError;
    PyUnicode_InternInPlace(&v);

methane closed this Jul 5, 2019
Copy link
Member Author

methane commented Jul 5, 2019

I'm sorry, I found it myself.

methane deleted the fix-refleak branch July 5, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jdemeyer jdemeyer requested changes

Assignees

No one assigned

Labels

awaiting core review skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants