[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented Jul 12, 2019 •
edited by bedevere-bot
Loading

Fix importlib examples to insert any newly created modules via importlib.util.module_from_spec() immediately into sys.modules instead of after calling loader.exec_module().

Thanks to Benjamin Mintz for finding the bug.

https://bugs.python.org/issue37521
(cherry picked from commit 0827064)

Co-authored-by: Brett Cannon 54418+brettcannon@users.noreply.github.com

https://bugs.python.org/issue37521

bpo-37521: No longer treat insertion into sys.modules as optional in …
50663a0 
…importlib examples (pythonGH-14723)

Fix importlib examples to insert any newly created modules via importlib.util.module_from_spec() immediately into sys.modules instead of after calling loader.exec_module().

Thanks to Benjamin Mintz for finding the bug.

https://bugs.python.org/issue37521
(cherry picked from commit 0827064)

Co-authored-by: Brett Cannon <54418+brettcannon@users.noreply.github.com>
bedevere-bot mentioned this pull request Jul 12, 2019
Merged
bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jul 12, 2019
Copy link
Contributor Author

miss-islington commented Jul 12, 2019

@brettcannon: Status check is done, and it's a success ✅ .

miss-islington merged commit bfb709b into python:3.8 Jul 12, 2019
miss-islington deleted the backport-0827064-3.8 branch July 12, 2019 22:51
Copy link
Contributor Author

miss-islington commented Jul 12, 2019

@brettcannon: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brettcannon brettcannon approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants