[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light

bpo-37579: Return NotImplemented in Python implementation of __eq__ to match C implementation of datetime for timedelta and time by tirkarthi · Pull Request #14726 · python/cpython

tirkarthi

added 2 commits

July 13, 2019 10:56
…types in Python implementation to match C implementation

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 13, 2019 

pythonGH-14726)

Returns NotImplemented for timedelta and time in __eq__ for different types in Python implementation, which matches the C implementation.

This also adds tests to enforce that these objects will fall back to the right hand side's __eq__ and/or __ne__ implementation.

bpo-37579
(cherry picked from commit e6b46aa)

Co-authored-by: Xtreak <tir.karthi@gmail.com>

tirkarthi added a commit to tirkarthi/cpython that referenced this pull request

Jul 13, 2019 

…nd time (pythonGH-14726)

Returns NotImplemented for timedelta and time in __eq__ for different types in Python implementation, which matches the C implementation.

This also adds tests to enforce that these objects will fall back to the right hand side's __eq__ and/or __ne__ implementation.

bpo-37579
(cherry picked from commit e6b46aa)

Co-authored-by: Xtreak <tir.karthi@gmail.com>

miss-islington added a commit that referenced this pull request

Jul 13, 2019 
GH-14726)

Returns NotImplemented for timedelta and time in __eq__ for different types in Python implementation, which matches the C implementation.

This also adds tests to enforce that these objects will fall back to the right hand side's __eq__ and/or __ne__ implementation.

bpo-37579
(cherry picked from commit e6b46aa)

Co-authored-by: Xtreak <tir.karthi@gmail.com>

Merged

lisroach pushed a commit to lisroach/cpython that referenced this pull request

Sep 10, 2019 
pythonGH-14726)

Returns NotImplemented for timedelta and time in __eq__ for different types in Python implementation, which matches the C implementation.

This also adds tests to enforce that these objects will fall back to the right hand side's __eq__ and/or __ne__ implementation.

bpo-37579

Merged

DinoV pushed a commit to DinoV/cpython that referenced this pull request

Jan 14, 2020 
pythonGH-14726)

Returns NotImplemented for timedelta and time in __eq__ for different types in Python implementation, which matches the C implementation.

This also adds tests to enforce that these objects will fall back to the right hand side's __eq__ and/or __ne__ implementation.

bpo-37579