[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented Jul 13, 2019

Returns NotImplemented for timedelta and time in eq for different types in Python implementation, which matches the C implementation.

This also adds tests to enforce that these objects will fall back to the right hand side's eq and/or ne implementation.

bpo-37579
(cherry picked from commit e6b46aa)

Co-authored-by: Xtreak tir.karthi@gmail.com

https://bugs.python.org/issue37579

pythonGH-14726)

Returns NotImplemented for timedelta and time in __eq__ for different types in Python implementation, which matches the C implementation.

This also adds tests to enforce that these objects will fall back to the right hand side's __eq__ and/or __ne__ implementation.

bpo-37579
(cherry picked from commit e6b46aa)

Co-authored-by: Xtreak <tir.karthi@gmail.com>
Copy link
Contributor Author

@tirkarthi and @pganssle: Status check is done, and it's a success ✅ .

miss-islington merged commit 143672c into python:3.8 Jul 13, 2019
miss-islington deleted the backport-e6b46aa-3.8 branch July 13, 2019 13:59
Copy link
Contributor Author

@tirkarthi and @pganssle: Status check is done, and it's a success ✅ .

1 similar comment
Copy link
Contributor Author

@tirkarthi and @pganssle: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants