[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

jdemeyer commented Jul 15, 2019 •
edited
Loading

Backport #13781 (part of the PEP 590 implementation) to 3.8 to fix a performance regression, see bpo-37562.

CC @vstinner @pablogsal @ambv

https://bugs.python.org/issue36974

jdemeyer mentioned this pull request Jul 15, 2019
Merged
Copy link
Member

pablogsal commented Jul 15, 2019

I will run pyperformance today to confirm if this fixes the regression. Thanks for the PR @jdemeyer!

rhettinger self-assigned this Jul 23, 2019
Copy link
Contributor

rhettinger commented Jul 23, 2019

I can confirm this fixes the performance regression. Please apply this backport.

ambv merged commit bf8e82f into python:3.8 Jul 23, 2019
Copy link

bedevere-bot commented Jul 23, 2019

@ambv: Please replace # with GH- in the commit message next time. Thanks!

Copy link
Contributor

ambv commented Jul 23, 2019

One day I'll remember to replace # with GH-. It will be a glorious day.

Copy link
Contributor

rhettinger commented Jul 23, 2019

Thanks for fixing this :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rhettinger rhettinger approved these changes

Assignees

rhettinger

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants