[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

jaketesler commented Jul 18, 2019 •
edited
Loading

This PR includes a minor documentation change. It adds a short blurb to the "What's New in Python 3.8" doc about the new Threading module Native ID functionality (threading.get_native_id(), et al.)

If this PR for :master is approved, I will create a backport PR for the :3.8 branch.

See #13463 (bpo-36084) for more information.

cc @vstinner, @pitrou

https://bugs.python.org/issue36084

eryksun reviewed Jul 18, 2019
View reviewed changes
jaketesler changed the title Add threading Native ID information to What's New documentation bpo-36084: Add threading Native ID information to What's New documentation Jul 24, 2019
Copy link
Contributor Author

jaketesler commented Jul 26, 2019

I didn't expect the Spanish Inquisition

Copy link

bedevere-bot commented Jul 26, 2019

Nobody expects the Spanish Inquisition!

: please review the changes made to this pull request.

Copy link
Contributor Author

jaketesler commented Jul 26, 2019

^ I did that since @bedevere-bot didn't initially add any labels and I didn't want this small PR to get lost in the fray.

Delete 2019-07-24-22-46-04.bpo-36084.2rmo4T.rst
395bac8 
Delete NEWS entry per @vstinner
Update 3.8 doc
1be1e95 
Update 3.8 doc wording to match `Threading` reference documentation
Copy link
Contributor Author

jaketesler commented Jul 30, 2019

@vstinner Updated the 3.8 doc per your suggestion.

vstinner merged commit 84846b0 into python:master Jul 30, 2019
Copy link
Contributor

miss-islington commented Jul 30, 2019

Thanks @jaketesler for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

Copy link

bedevere-bot commented Jul 30, 2019

GH-15028 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 30, 2019
bpo-36084: Add threading Native ID information to What's New document…
32c0b1b 
…ation (pythonGH-14845)

(cherry picked from commit 84846b0)

Co-authored-by: Jake Tesler <jake.tesler@gmail.com>
miss-islington added a commit that referenced this pull request Jul 30, 2019
bpo-36084: Add threading Native ID information to What's New document…
7026737 
…ation (GH-14845)

(cherry picked from commit 84846b0)

Co-authored-by: Jake Tesler <jake.tesler@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
bpo-36084: Add threading Native ID information to What's New document…
d77c7b6 
…ation (pythonGH-14845)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
bpo-36084: Add threading Native ID information to What's New document…
801127a 
…ation (pythonGH-14845)
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
bpo-36084: Add threading Native ID information to What's New document…
594ac05 
…ation (pythonGH-14845)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments

eryksun eryksun left review comments

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants