[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented Aug 29, 2019

  • Fix call_matcher for mock when using methods

  • Add NEWS entry

  • Use None check and convert doctest to unittest

  • Use better name for mock in tests. Handle _SpecState when the attribute was not accessed and add tests.

  • Use reset_mock instead of reinitialization. Change inner class constructor signature for check

  • Reword comment regarding call object lookup logic
    (cherry picked from commit c961278)

Co-authored-by: Xtreak tir.karthi@gmail.com

https://bugs.python.org/issue36871

…to a method (GH13261)

* Fix call_matcher for mock when using methods

* Add NEWS entry

* Use None check and convert doctest to unittest

* Use better name for mock in tests. Handle _SpecState when the attribute was not accessed and add tests.

* Use reset_mock instead of reinitialization. Change inner class constructor signature for check

* Reword comment regarding call object lookup logic
(cherry picked from commit c961278)

Co-authored-by: Xtreak <tir.karthi@gmail.com>
Copy link
Contributor Author

@tirkarthi and @cjw296: Status check is done, and it's a success ✅ .

2 similar comments
Copy link
Contributor Author

@tirkarthi and @cjw296: Status check is done, and it's a success ✅ .

Copy link
Contributor Author

@tirkarthi and @cjw296: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants