[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

pierreglaser commented Sep 10, 2019 •
edited
Loading

I guess it also needs a backport to 3.8 and 3.7.

Also, I still haven't a proper reproducer and this bothers me...

pinging @zooba

https://bugs.python.org/issue38092

zooba requested changes Sep 10, 2019
View reviewed changes
Copy link
Member

zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the change to the default Python executable as we discussed on the issue.

Copy link

bedevere-bot commented Sep 10, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

zooba mentioned this pull request Sep 13, 2019
Merged
zooba closed this Sep 13, 2019
Copy link
Member

zooba commented Sep 13, 2019

Thanks for the PR! I completed it in #16098 with the rest of the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zooba zooba requested changes

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants