[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

serhiy-storchaka commented Sep 12, 2019 •
edited by bedevere-bot
Loading

serhiy-storchaka added the type-feature A feature request or enhancement label Sep 12, 2019
ZackerySpytz reviewed Jun 9, 2020
View reviewed changes
Lib/glob.py
return stat.S_ISDIR(st.st_mode)

def _join(dirname, basename):
# It is common if dirname or basename is empty
Copy link
Contributor

ZackerySpytz Jun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this comment is necessary.

Copy link
Member Author

serhiy-storchaka Jun 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not? It explains why the special case was added.

Or maybe you can suggest better wording?

serhiy-storchaka merged commit 8a64cea into python:master Jun 18, 2020
serhiy-storchaka deleted the glob-root_dir-dir_fd branch June 18, 2020 19:08
fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
bpo-38144: Add the root_dir and dir_fd parameters in glob.glob(). (py…
2558875 
…thonGH-16075)
PhilippWendler mentioned this pull request Jul 7, 2020
Open
serhiy-storchaka mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

ZackerySpytz ZackerySpytz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants