[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented Sep 17, 2019

In the format string for assert_called the evaluation order is incorrect and hence for mock's without name, 'None' is printed whereas it should be 'mock' like for other messages. The error message is ("Expected '%s' to have been called." % self._mock_name or 'mock').
(cherry picked from commit 5f5f11f)

Co-authored-by: Abraham Toriz Cruz awonderfulcode@gmail.com

https://bugs.python.org/issue37828

…pythonGH-16166)

In the format string for assert_called the evaluation order is incorrect and hence for mock's without name, 'None' is printed whereas it should be 'mock' like for other messages. The error message is ("Expected '%s' to have been called." % self._mock_name or 'mock').
(cherry picked from commit 5f5f11f)

Co-authored-by: Abraham Toriz Cruz <awonderfulcode@gmail.com>
Copy link
Contributor Author

@categulario and @pablogsal: Status check is done, and it's a success ✅ .

miss-islington merged commit f668d2b into python:3.8 Sep 17, 2019
miss-islington deleted the backport-5f5f11f-3.8 branch September 17, 2019 11:35
Copy link
Contributor Author

@categulario and @pablogsal: Status check is done, and it's a success ✅ .

1 similar comment
Copy link
Contributor Author

@categulario and @pablogsal: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants