[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

ericsnowcurrently commented May 17, 2017

Copy link

mention-bot commented May 17, 2017

@ericsnowcurrently, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zooba, @birkenfeld and @ncoghlan to be potential reviewers.

vstinner reviewed May 17, 2017
View reviewed changes
Doc/c-api/init.rst Outdated
Copy link
Member

vstinner May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.6 now uses stdint.h: please use directly uint64_t.

Copy link
Member Author

ericsnowcurrently May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why unsigned? Did you mean int64_t?

Copy link
Member

vstinner May 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, int64_t. By the way, extract of master:

#define PY_INT64_T int64_t

ericsnowcurrently force-pushed the interpreter-id branch 5 times, most recently from 4bcf3f2 to da8439a Compare May 21, 2017 06:04
ericsnowcurrently merged commit e377416 into python:master May 23, 2017
ericsnowcurrently deleted the interpreter-id branch May 23, 2017 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments

zooba zooba approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants