[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

Kentzo commented Nov 12, 2019 •
edited by bedevere-bot
Loading

Due to:
[bpo-26467](#9296): large chunk of the "based on" Apache 2.0 licensed code
[bpo-29302](#4790)

Missing ack
387ffc7 
bpo-26467: large chunk of the "based on" code
bpo-29302
brandtbucher added skip issue skip news docs Documentation in the Doc dir labels Nov 12, 2019
brandtbucher approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help!

benjaminp merged commit d6d6e2a into python:master Nov 13, 2019
Copy link
Contributor

miss-islington commented Nov 13, 2019

Thanks @Kentzo for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

Copy link

bedevere-bot commented Nov 13, 2019

GH-17138 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Nov 13, 2019
Add Ilya Kulakov to Misc/ACKS. (GH-17130)
e5125f7 
Contributions on bpo-26467 and bpo-29302.
(cherry picked from commit d6d6e2a)

Co-authored-by: Ilya Kulakov <kulakov.ilya@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
Add Ilya Kulakov to Misc/ACKS. (pythonGH-17130)
9844b12 
Contributions on bpo-26467 and bpo-29302.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Add Ilya Kulakov to Misc/ACKS. (pythonGH-17130)
39c406a 
Contributions on bpo-26467 and bpo-29302.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brandtbucher brandtbucher approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants