[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented Dec 18, 2019 •
edited by bedevere-bot
Loading

Fix test_ressources_gced_in_workers() of test_concurrent_futures:
explicitly stop the manager to prevent leaking a child process
running in the background after the test completes.

(cherry picked from commit 673c393)
(cherry picked from commit b0eb046)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue38546

bpo-38546: Fix concurrent.futures test_ressources_gced_in_workers() (p…
3618f82 
…ythonGH-17652) (pythonGH-17655)

Fix test_ressources_gced_in_workers() of test_concurrent_futures:
explicitly stop the manager to prevent leaking a child process
running in the background after the test completes.

(cherry picked from commit 673c393)
(cherry picked from commit b0eb046)

Co-authored-by: Victor Stinner <vstinner@python.org>
bedevere-bot mentioned this pull request Dec 18, 2019
Merged
bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Dec 18, 2019
vstinner approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Copy link
Contributor Author

miss-islington commented Dec 18, 2019

@vstinner: Status check is done, and it's a success ✅ .

miss-islington merged commit b8bbdf0 into python:3.7 Dec 18, 2019
miss-islington deleted the backport-b0eb046-3.7 branch December 18, 2019 20:51
Copy link
Contributor Author

miss-islington commented Dec 18, 2019

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants