[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

corona10 commented Jan 1, 2020 •
edited
Loading

corona10 requested review from benjaminp and vstinner January 1, 2020 09:48
corona10 changed the title bpo-38871: Fix lib2to3 to be able to use in edge cases of filter [WIP] bpo-38871: Fix lib2to3 to be able to use in edge cases of filter Jan 1, 2020
corona10 changed the title [WIP] bpo-38871: Fix lib2to3 to be able to use in edge cases of filter bpo-38871: Fix lib2to3 to be able to use in edge cases of filter Jan 1, 2020
pablogsal self-requested a review January 3, 2020 19:16
pablogsal self-assigned this Jan 3, 2020
Copy link
Member

vstinner commented Jan 6, 2020

@benjaminp @pablogsal @isidentical: Would you mind to have a look?

pablogsal requested changes Jan 6, 2020
View reviewed changes
Copy link

bedevere-bot commented Jan 6, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Member Author

corona10 commented Jan 7, 2020

I have made the requested changes; please review again

Copy link

bedevere-bot commented Jan 7, 2020

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.

bedevere-bot requested a review from pablogsal January 7, 2020 02:52
pablogsal reviewed Jan 7, 2020
View reviewed changes
corona10 requested a review from pablogsal January 7, 2020 12:22
vstinner merged commit b821173 into python:master Jan 7, 2020
Copy link
Contributor

miss-islington commented Jan 7, 2020

Thanks @corona10 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 7, 2020
bpo-38871: Fix lib2to3 for filter-based statements that contain lambda (
3ce3a3d 
pythonGH-17780)

Correctly parenthesize filter-based statements that contain lambda
expressions in lib2to3.
(cherry picked from commit b821173)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
Copy link

bedevere-bot commented Jan 7, 2020

GH-17899 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 7, 2020
bpo-38871: Fix lib2to3 for filter-based statements that contain lambda (
d6a9419 
pythonGH-17780)

Correctly parenthesize filter-based statements that contain lambda
expressions in lib2to3.
(cherry picked from commit b821173)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
Copy link
Member

vstinner commented Jan 7, 2020

Thanks @corona10 for updating the NEWS entry. I rewrote the commit message.

Copy link

bedevere-bot commented Jan 7, 2020

GH-17900 is a backport of this pull request to the 3.7 branch.

Copy link
Member

pablogsal commented Jan 7, 2020

Thanks for the PR, @corona10 !

miss-islington added a commit that referenced this pull request Jan 7, 2020
bpo-38871: Fix lib2to3 for filter-based statements that contain lambda (
535a3c4 
GH-17780)

Correctly parenthesize filter-based statements that contain lambda
expressions in lib2to3.
(cherry picked from commit b821173)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
miss-islington added a commit that referenced this pull request Jan 7, 2020
bpo-38871: Fix lib2to3 for filter-based statements that contain lambda (
39a5c88 
GH-17780)

Correctly parenthesize filter-based statements that contain lambda
expressions in lib2to3.
(cherry picked from commit b821173)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
bpo-38871: Fix lib2to3 for filter-based statements that contain lambda (
1c82b88 
pythonGH-17780)

Correctly parenthesize filter-based statements that contain lambda
expressions in lib2to3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal pablogsal approved these changes

benjaminp Awaiting requested review from benjaminp

vstinner Awaiting requested review from vstinner

Assignees

pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants