[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link

LucianaMarques commented Jan 17, 2020 •
edited by bedevere-bot
Loading

  • Join two classes (NNTP and _NNTPBase)
  • Modify one test accordingly

https://bugs.python.org/issue39305

bpo-39305: Refactor nntplib.py
fb4d85f 
* Join two classes (NNTP and _NNTPBase)
* Modify one test accordingly
Copy link
Author

LucianaMarques commented Jan 17, 2020 •
edited
Loading

@corona10 and @vstinner this PR is in reference of bpo-39305, could you please take a look when you have a chance?

Thanks :)

LucianaMarques mentioned this pull request Jan 17, 2020
Closed
csabella requested review from corona10 and vstinner January 18, 2020 02:57
corona10 requested changes Jan 18, 2020
View reviewed changes
Lib/nntplib.py

def __init__(self, file, host,
readermode=None, timeout=_GLOBAL_DEFAULT_TIMEOUT):
def __init__(self, host, file=None,
Copy link
Member

corona10 Jan 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to add a new parameter file for NNTP.

Copy link
Author

LucianaMarques Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will change this.

Copy link
Author

LucianaMarques commented Jan 21, 2020

Hi, just wanted to register here I have been away for a few days but I'm working on this today.

Copy link
Author

LucianaMarques commented Jan 30, 2020

Hi there, I'm sorry for the absence here, I will come back to this shortly!

Copy link
Member

corona10 commented May 16, 2020

@LucianaMarques
This issue is solved by #19817 :)
Thanks for the work, I am looking forward to your future contribution!

corona10 closed this May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

corona10 corona10 requested changes

vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants