[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

methane commented Jan 20, 2020 •
edited
Loading

ammaraskar reviewed Jan 20, 2020
View reviewed changes
Update Misc/NEWS.d/next/Library/2020-01-20-13-00-35.bpo-39377.QSFdaU.rst
605b23a 
Co-Authored-By: Ammar Askar <ammar_askar@hotmail.com>
methane merged commit 5492bfc into python:master Jan 20, 2020
methane deleted the remove-json-encoding branch January 20, 2020 04:54
sthagen added a commit to sthagen/python-cpython that referenced this pull request Jan 20, 2020
Merge pull request #193 from python/master
ee4c047 
bpo-39377: json: Remove the encoding option. (pythonGH-18075)
Copy link
Member

ammaraskar commented Jan 20, 2020

Oh sorry, I missed that there was a mention of encoding in https://github.com/python/cpython/blob/master/Doc/library/json.rst on line 286:

The other arguments have the same meaning as in :func:load, except
encoding which is ignored and deprecated since Python 3.1.

Should this be removed as well?

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
bpo-39377: json: Remove the encoding option. (pythonGH-18075)
1365a52
This was referenced Jul 16, 2020
Open
Closed
Closed
tirkarthi mentioned this pull request Aug 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ammaraskar ammaraskar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants