[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

mbarkhau commented Jan 24, 2020 •
edited by bedevere-bot
Loading

(cherry picked from commit 8870433)

Co-authored-by: mbarkhau mbarkhau@gmail.com

https://bugs.python.org/issue39390

bedevere-bot mentioned this pull request Jan 24, 2020
Merged
mbarkhau requested a review from giampaolo January 24, 2020 16:03
Copy link
Contributor

giampaolo commented Jan 24, 2020

Since this is a regression, I think it deserves an entry at the bottom of Docs/whatsnew:

Notable changes in Python 3.8.2
===============================

Fixed a regression with the `ignore` callback of :func:`shutil.copytree`.
The argument types are now str and List[str] again.

Copy link
Contributor Author

mbarkhau commented Jan 27, 2020

Sorry, I missed your comment, will have a look at this later today.

mbarkhau force-pushed the backport-8870433-3.8 branch from 778ba9c to 4c7cd9b Compare January 27, 2020 19:46
[3.8] bpo-39390 shutil: fix argument types for ignore callback (pytho…
e08eb83 
…nGH-18122).

(cherry picked from commit 8870433)

Co-authored-by: mbarkhau <mbarkhau@gmail.com>
mbarkhau force-pushed the backport-8870433-3.8 branch from 4c7cd9b to e08eb83 Compare January 27, 2020 19:58
giampaolo merged commit cf9d005 into python:3.8 Jan 27, 2020
Copy link
Contributor

giampaolo commented Jan 27, 2020

Merged, thanks.

mbarkhau deleted the backport-8870433-3.8 branch January 28, 2020 06:49
Copy link
Contributor Author

mbarkhau commented Jan 28, 2020

And thank you for the hand holding ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

giampaolo Awaiting requested review from giampaolo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants