[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

mmohrhard commented Feb 11, 2020 •
edited by miss-islington
Loading

Just a small debugging improvement to identify the asyncio executor threads.

https://bugs.python.org/issue39609

Automerge-Triggered-By: @asvetlov

mmohrhard force-pushed the bpo39609-add_thread_name_prefix_to_asyncio_executor branch from 7ca1ec6 to b9078e6 Compare February 11, 2020 11:46
Copy link

codecov bot commented Feb 11, 2020 •
edited
Loading

Codecov Report

Merging #18458 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #18458      +/-   ##
==========================================
- Coverage   82.20%   82.12%   -0.09%     
==========================================
  Files        1957     1954       -3     
  Lines      589324   583606    -5718     
  Branches    44428    44428              
==========================================
- Hits       484430   479259    -5171     
+ Misses      95233    94702     -531     
+ Partials     9661     9645      -16
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-12.86%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Lib/dbm/__init__.py 66.66% <0.00%> (-4.45%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.87%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
... and 317 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb9f43...b9078e6. Read the comment docs.

asvetlov reviewed Feb 24, 2020
View reviewed changes
Lib/asyncio/base_events.py Outdated
Copy link
Contributor

asvetlov Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A shorter name is better, please apply it.

Suggested change
thread_name_prefix='asyncio_default_executor'
thread_name_prefix='asyncio'

mmohrhard force-pushed the bpo39609-add_thread_name_prefix_to_asyncio_executor branch from b9078e6 to d9d31c9 Compare February 27, 2020 19:32
Copy link
Contributor

miss-islington commented Feb 27, 2020

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

miss-islington merged commit 374d998 into python:master Feb 27, 2020
Copy link
Contributor

asvetlov commented Feb 27, 2020

Thanks!

sthagen mentioned this pull request Feb 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

asvetlov asvetlov approved these changes

1st1 Awaiting requested review from 1st1

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants