[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

ananthan-123 commented Feb 18, 2020 •
edited by bedevere-bot
Loading

ananthan-123 requested review from gvanrossum and ilevkivskyi and removed request for gvanrossum and ilevkivskyi February 18, 2020 18:22
ananthan-123 changed the title bpo-39572:documented _total_ attribute of TypeDict bpo-39572:documented _total_ attribute of TypedDict Feb 18, 2020
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #18554 into master will increase coverage by 1.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #18554       +/-   ##
===========================================
+ Coverage   82.11%   83.19%    +1.08%     
===========================================
  Files        1956     1571      -385     
  Lines      589145   414757   -174388     
  Branches    44447    44457       +10     
===========================================
- Hits       483801   345075   -138726     
+ Misses      95697    60030    -35667     
- Partials     9647     9652        +5
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 452 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fac7ed...d5b6107. Read the comment docs.

Copy link
Member

gvanrossum commented Feb 19, 2020

Note that the importlib failure is pre-existing (and presumably being worked on). I'll try to review later, but I am going out of town for a ew days.

gvanrossum requested changes Feb 19, 2020
View reviewed changes
Copy link

bedevere-bot commented Feb 19, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

gvanrossum reviewed Feb 19, 2020
View reviewed changes
Copy link
Member

gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attribute -> flag, and you’re golden.

gvanrossum merged commit ab6423f into python:master Feb 19, 2020
Copy link
Contributor

miss-islington commented Feb 19, 2020

Thanks @ananthan-123 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

Copy link

bedevere-bot commented Feb 19, 2020

GH-18556 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Feb 19, 2020
bpo-39572: Document ’total’ flag of TypedDict (GH-18554)
44c6901 
(cherry picked from commit ab6423f)

Co-authored-by: ananthan-123 <ananthakrishnan15.2001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes

ilevkivskyi Awaiting requested review from ilevkivskyi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants