[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

serhiy-storchaka commented May 30, 2017

serhiy-storchaka added the type-feature A feature request or enhancement label May 30, 2017
Copy link

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @loewis and @tim-one to be potential reviewers.

Copy link
Member

@serhiy-storchaka if Parser/token.c is auto-generated by the tool, why do you include it in this PR ?

serhiy-storchaka requested a review from a team as a code owner April 14, 2018 12:23
Copy link
Member

Nice cleaning up of the code. Generally LGTM.

Tools/scripts/generate_token_h.py and Tools/scripts/generate_token_rst.py are very similar, it would be neater to merge them.

pablogsal self-assigned this Sep 25, 2018
Copy link
Member Author

Created alternate PR #10370 which takes all information from Grammar/Tokens and use a single generating script.

Copy link
Member Author

Tools/scripts/generate_token_h.py, Tools/scripts/generate_token_rst.py and Tools/scripts/generate_token_c.py have been merged into Tools/scripts/generate_token.py. See also #10370.

Copy link
Member Author

Closed in favor of #10370.

serhiy-storchaka deleted the regen-token branch December 22, 2018 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants