[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

vstinner commented Mar 3, 2020 •
edited by bedevere-bot
Loading

This reverts commit e471e72.

The mode will be removed from Python 3.10.

https://bugs.python.org/issue39674

bpo-39674: Revert "bpo-37330: open() no longer accept 'U' in file mode (
f6a073f 
GH-16959)"

This reverts commit e471e72.

The mode will be removed from Python 3.10.
Copy link
Member Author

vstinner commented Mar 3, 2020

@tirkarthi @serhiy-storchaka: You approved PR #16959. Would you mind to review this revert? See https://bugs.python.org/issue39674 for the rationale.

tirkarthi approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since it seems to be a straightforward revert of the commit. Thanks Victor.

fabioz mentioned this pull request Mar 4, 2020
Open
vstinner merged commit 942f7a2 into python:master Mar 4, 2020
Copy link
Member Author

vstinner commented Mar 4, 2020

Thanks for the review @tirkarthi ;-)

vstinner deleted the revert_u_mode branch March 4, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tirkarthi tirkarthi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants