[proxy] github.com← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

miss-islington commented Mar 9, 2020

python-gdb.py now checks for "take_gil" function name to check if a
frame tries to acquire the GIL, instead of checking for
"pthread_cond_timedwait" which is specific to Linux and can be a
different condition than the GIL.
(cherry picked from commit 6d0ee60)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue36184

python-gdb.py now checks for "take_gil" function name to check if a
frame tries to acquire the GIL, instead of checking for
"pthread_cond_timedwait" which is specific to Linux and can be a
different condition than the GIL.
(cherry picked from commit 6d0ee60)

Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

miss-islington merged commit 5854d45 into python:3.8 Mar 9, 2020
miss-islington deleted the backport-6d0ee60-3.8 branch March 9, 2020 18:52
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

1 similar comment
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants