[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

furkanonder commented Mar 16, 2020 •
edited by bedevere-bot
Loading

bedevere-bot added docs Documentation in the Doc dir awaiting review labels Mar 16, 2020
isidentical reviewed Mar 16, 2020
View reviewed changes
Copy link
Member

isidentical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

furkanonder requested a review from isidentical March 16, 2020 09:51
Update Doc/reference/datamodel.rst
e48cc00 
Co-Authored-By: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
zware requested changes Mar 17, 2020
View reviewed changes
Copy link
Member

zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also my comment on the issue.

Copy link

bedevere-bot commented Mar 17, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

furkanonder requested a review from zware March 17, 2020 23:17
Copy link
Contributor Author

furkanonder commented Mar 26, 2020

It was combined with another pr. => #19006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

isidentical Awaiting requested review from isidentical

zware Awaiting requested review from zware

1 more reviewer

hakancelikdev hakancelikdev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting changes docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants