[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

vstinner commented Mar 18, 2020 •
edited by bedevere-bot
Loading

bpo-37127, bpo-39984:

  • trip_signal() and Py_AddPendingCall() now get the current Python
    thread state using PyGILState_GetThisThreadState() rather than
    _PyRuntimeState_GetThreadState() to be able to get it even if the
    GIL is released.
  • _PyEval_SignalReceived() now expects tstate rather than ceval.
  • Remove ceval parameter of _PyEval_AddPendingCall(): ceval is now
    get from tstate parameter.

https://bugs.python.org/issue39984

bpo-39984: trip_signal() uses PyGILState_GetThisThreadState()
6c7c04d 
bpo-37127, bpo-39984:

* trip_signal() and Py_AddPendingCall() now get the current Python
  thread state using PyGILState_GetThisThreadState() rather than
  _PyRuntimeState_GetThreadState() to be able to get it even if the
  GIL is released.
* _PyEval_SignalReceived() now expects tstate rather than ceval.
* Remove ceval parameter of _PyEval_AddPendingCall(): ceval is now
  get from tstate parameter.
Copy link
Member Author

vstinner commented Mar 18, 2020

Py_AddPendingCall() and trip_signal() have an issue if the thread has no Python thread state. But this PR doesn't make the situation better or worse, the problem already existed before. See: https://bugs.python.org/issue37127#msg364543

vstinner merged commit 8849e59 into python:master Mar 18, 2020
vstinner deleted the pending_tstate branch March 18, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants