There was a problem hiding this comment.
It looks a bit odd to see:
LOOPBACK_TIMEOUT = 10
elif sys.platform == 'vxworks':
LOOPBACK_TIMEOUT = 10
but I suppose adding an OR after the existing AND condition would also be awkward. I'll leave it to your (or someone else's) judgment.
(Especially) if you are going to keep it a separate clause, I would like to see a comment explaining why. For instance, "vxworks is used on embedded devices, and some boards are quite slow; avoid false alarms"
|
Two comments, but it is possible they will lead to no change, and likely they will lead to nothing bigger than a comment. Consider this a positive review for triage/commit purposes. |
VxWorks might run on some low-performance board. If TLS is enabled with ftp, it needs bigger LOOPBACK_TIMEOUT value. Otherwise, some test cases under test.test_ftplib.TestTLS_FTPClassMixin will fail. The value 10 is enough to prevent test failure.
https://bugs.python.org/issue31904