[proxy] github.com — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

corona10 commented Apr 30, 2020 •
edited by bedevere-bot
Loading

corona10 requested a review from vstinner April 30, 2020 15:24
Copy link
Member Author

corona10 commented Apr 30, 2020

@vstinner Ready to review!

Copy link
Member Author

corona10 commented May 5, 2020

@vstinner gentle ping

corona10 requested a review from ericvsmith May 14, 2020 15:27
Copy link
Member Author

corona10 commented May 14, 2020

@ericvsmith Would you mind to take a look at this PR?

corona10 requested a review from warsaw May 14, 2020 15:39
Copy link
Member Author

corona10 commented May 14, 2020

Can you please take a look also? @warsaw :)

ericvsmith reviewed May 14, 2020
View reviewed changes
Copy link
Member

ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments. I think it generally looks okay.

ericvsmith approved these changes May 16, 2020
View reviewed changes
Copy link
Member

ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

corona10 commented May 16, 2020
View reviewed changes
Copy link
Member Author

corona10 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericvsmith Thank you Eric, I will merge it after the CI is passed :)

corona10 merged commit aa92a7c into python:master May 16, 2020
corona10 mentioned this pull request May 16, 2020
Closed
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
bpo-39305: Update nntplib to merge nntplib.NNTP and nntplib._NNTPBase (…
babe102 
…pythonGH-19817)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericvsmith ericvsmith approved these changes

vstinner Awaiting requested review from vstinner

warsaw Awaiting requested review from warsaw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants